-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch the IDE with codium (instead of vscodium) #176
Launch the IDE with codium (instead of vscodium) #176
Conversation
I certainly also need to adapt the symlink in the AppImage recipe. I'm not sure if the changed I'm a bit reluctant (read: lazy) to install the development dependencies on my machine and run the build locally (I know, shame on me! 😬), so every helpful hint is appreciated. |
Can someone help me understand where Electron/Gulp builds the final binary? Looks like it's not built inside the code tree... 😟 @stripedpajamas maybe? I'm from a different planet, don't know the place, sorry! 😬 |
What OS are you building? It puts it in a different place for each OS. If you look at the deploy step in the Travis file you can see the paths we pull from (for instance, the Mac binary gets placed in a folder one level up from the vscode folder which we then zip). |
Sure. How do we verify that the changes actually do what we want? (I'll remove the unneeded commits and squash everything to a single commit once we're done. No worries!) |
Unfortunately verifying the results takes a lot of hoop jumping. I am writing up a contributor's guide now, but it involves setting up a Travis environment with GH credentials and letting it build+deploy the binaries to your fork. Two options:
If you have VSCodium installed, you should be able to edit your own product.json, change the application name to codium and then start it up. Then go to the command pallette and "install codium alias to the PATH" and then confirm it works in your terminal. More info on the latter part of those steps in the DOCS.md file in this repo. Thanks for your help 👍 |
I'd be fine if you merged the change right away. I've undone all commits except the ones doing the application name change. I would guess the Debian package also has code that creates the symlink The "install codium alias to the PATH" (or similar) doesn't exist in my VSCodium command palette. Not sure why. |
* Update VSCodium binary name The binary name of VSCodium has [changed](VSCodium/vscodium#176). * Update VSCodium binary name
Everyone installing VSCodium from packages, note:
Be sure to uninstall $ sudo apt-get install codium
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
codium
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 48.6 MB of archives.
After this operation, 195 MB of additional disk space will be used.
Get:1 https://gitlab.com/paulcarroty/vscodium-deb-rpm-repo/raw/repos/debs vscodium/main amd64 codium amd64 1.35.0-1560135863 [48.6 MB]
Fetched 48.6 MB in 4s (11.2 MB/s)
Selecting previously unselected package codium.
(Reading database ... 297797 files and directories currently installed.)
Preparing to unpack .../codium_1.35.0-1560135863_amd64.deb ...
Unpacking codium (1.35.0-1560135863) ...
dpkg: error processing archive /var/cache/apt/archives/codium_1.35.0-1560135863_amd64.deb (--unpack):
trying to overwrite '/usr/share/pixmaps/com.visualstudio.code.oss.png', which is also in package vscodium 1.34.0-1558029460
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
Errors were encountered while processing:
/var/cache/apt/archives/codium_1.35.0-1560135863_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1) All the settings and projects will still be there with |
We want to run VSCodium via
codium
in the terminal. This aligns with the non-free binary distribution and should make transitioning easier w.r.t. muscle memory.Fixes #36.