Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codium as app executable name instead of vscodium? #36

Closed
435vic opened this issue Oct 10, 2018 · 14 comments · Fixed by #176
Closed

codium as app executable name instead of vscodium? #36

435vic opened this issue Oct 10, 2018 · 14 comments · Fixed by #176

Comments

@435vic
Copy link

435vic commented Oct 10, 2018

The titles, names, and executables in the official and OSS versions all are variations of code and code-oss respectively. Maybe we should keep the pattern by making the executable codium? Also I think the Visual Studio name is copyrighted by Microsoft, not sure, but we might as well be careful. Something else I like about the original code executable is that it's very quick to type, enabling commands like code ~/very/big/path feel more fluent and quick.

@JL2210
Copy link
Contributor

JL2210 commented Oct 10, 2018

See number #28.

@435vic
Copy link
Author

435vic commented Oct 10, 2018

I see... Well, that does make sense. Thank you!

@435vic 435vic closed this as completed Oct 10, 2018
@drasbeck
Copy link

drasbeck commented Nov 29, 2018

I like the idea of codium instead of vscodium, because it eases the onboarding of new users.

@435vic, if things stay unchanged (and it looks like they do) you could always just create a symlink to vscodium, called codium.

@JL2210
Copy link
Contributor

JL2210 commented Apr 29, 2019 via email

@dzmitry-lahoda
Copy link

dzmitry-lahoda commented Apr 29, 2019

For pwsh:

New-Alias code vscodium

@JL2210
Copy link
Contributor

JL2210 commented Apr 29, 2019 via email

@stripedpajamas
Copy link
Member

I think @dzmitry-lahoda is on Windows @JL2210

@bittner
Copy link
Contributor

bittner commented May 28, 2019

Can we reopen this issue? I'd like to fix this problem for everyone.

@bittner
Copy link
Contributor

bittner commented May 28, 2019

Personally, I'd like to stick to the pattern that the non-free distribution follows:

  • VSCode --> code
  • VSCodium --> codium

That will make it also easier for developers transitioning from VSCode to VSCodium.
Muscle memory is a thing that is hard to overcome.

@stripedpajamas
Copy link
Member

All yours @bittner 💙

This is a breaking change, so proceed with caution. Making the change should be simple (change product.json pre-build). I suppose we will need a big notice in the changelog of the next release that lets people know that vscodium will no longer work (and therefore anyone who has alias code=vscodium will break as well). I'm not sure if any extensions are affected. Some extensions try to call the binary itself... I remember this coming up in an issue a couple of weeks ago but I don't recall where it ended up.

@bittner
Copy link
Contributor

bittner commented May 29, 2019

Cool, thank you!

I'm not totally sure, but shouldn't it possible to simply change the value for applicationName in build.sh? I'll try that in a PR. I hope the build will tell me when things break.

Do we have functional tests? I don't see any. We may want to add a simple one (à la "run codium --version") to the before_deploy: block or after calling ./build.sh in .travis.yml.

@stripedpajamas
Copy link
Member

Yes that's where the change should be made -- that's the part that updates the product.json file right before building.

@bittner
Copy link
Contributor

bittner commented Jun 12, 2019

Everyone looking into upgrading your vscodium package, please read my hints in the PR. 👀

Thanks @stripedpajamas and @paulcarroty! 🥇 🥂 🍾

@drasbeck
Copy link

Thanks @bittner. 💪

Now I'm happily waiting for this change to silently appear via homebrew.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants