Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU/GPUモードの状態をタイトルに追加 #757

Merged
merged 1 commit into from
Mar 14, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/MenuBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
(isEdited ? "*" : "") +
(projectName !== undefined ? projectName + " - " : "") +
"VOICEVOX" +
(currentVersion ? " - Ver. " + currentVersion : "")
(currentVersion ? " - Ver. " + currentVersion + " - " : "") +
(useGpu ? "GPU" : "CPU")
Copy link
Contributor Author

@o108minmin o108minmin Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

タイトルに関する以前の議論 #599 (comment) を読んで、なるべく短い方が良さそうだと思い CPU or GPU という短い表記にしてみました。

CPU mode or GPU mode という表記も考えたのですが、何かあればレビュワーの方のご意見を伺いたいです

}}
</div>
<q-space />
Expand Down Expand Up @@ -91,6 +92,7 @@ export default defineComponent({
const uiLocked = computed(() => store.getters.UI_LOCKED);
const menubarLocked = computed(() => store.getters.MENUBAR_LOCKED);
const projectName = computed(() => store.getters.PROJECT_NAME);
const useGpu = store.state.useGpu;
const isEdited = computed(() => store.getters.IS_EDITED);
const isFullscreen = computed(() => store.getters.IS_FULLSCREEN);

Expand Down Expand Up @@ -398,6 +400,7 @@ export default defineComponent({
subMenuOpenFlags,
reassignSubMenuOpen,
menudata,
useGpu,
};
},
});
Expand Down