CPU/GPUモードの状態をタイトルに追加 #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o108minmin
commented
Mar 14, 2022
| @@ -22,7 +22,8 @@ | |||
| (isEdited ? "*" : "") + | |||
| (projectName !== undefined ? projectName + " - " : "") + | |||
| "VOICEVOX" + | |||
| (currentVersion ? " - Ver. " + currentVersion : "") | |||
| (currentVersion ? " - Ver. " + currentVersion + " - " : "") + | |||
| (useGpu ? "GPU" : "CPU") | |||
There was a problem hiding this comment.
タイトルに関する以前の議論 #599 (comment) を読んで、なるべく短い方が良さそうだと思い CPU or GPU という短い表記にしてみました。
CPU mode or GPU mode という表記も考えたのですが、何かあればレビュワーの方のご意見を伺いたいです
|
初めてのprになります。迷った点はコメントしてあるので、何かあればご意見いただけると嬉しいです |
Hiroshiba
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
windowのタイトルにCPU/GPUモードの状態を載せます。
関連 Issue
ref #694
スクリーンショット・動画など
npm run electron:serveCPUの文字列を追加対応GPUを有する実機がないため、別ブランチでダミーを仕込んで実験済み o108minmin@f3e9499
その他