Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: フレーズのレンダリングでエラーになることがあるのを修正 #2271

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
phraseのstateを更新していなかったのを修正
sigprogramming committed Sep 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 87000b093fc2960c28c235bd9a28c9ae0f2bbc53
4 changes: 3 additions & 1 deletion src/store/singing.ts
Original file line number Diff line number Diff line change
@@ -1695,7 +1695,9 @@ export const singingStore = createPartialStore<SingingStoreTypes>({
foundPhrase.trackId,
phraseKey,
);
if (renderStartStageId != undefined) {
if (renderStartStageId == undefined) {
phrase.state = "PLAYABLE";
} else {
Comment on lines +1698 to +1700
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phraseRenderer.determineStartStageの戻り値がundefinedの場合はレンダリングの必要はないですが、phrase.stateを更新しておらず"WAITING_TO_BE_RENDERED"のままになってしまっていたので、"PLAYABLE"に設定するようにしました。

renderStartStageIds.set(phraseKey, renderStartStageId);
phrase.state = "WAITING_TO_BE_RENDERED";
}