Fix: フレーズのレンダリングでエラーになることがあるのを修正 #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
requested review from
Hiroshiba
and removed request for
a team
sigprogramming
commented
Sep 23, 2024
Comment on lines
+1698
to
+1700
| if (renderStartStageId == undefined) { | ||
| phrase.state = "PLAYABLE"; | ||
| } else { |
There was a problem hiding this comment.
phraseRenderer.determineStartStageの戻り値がundefinedの場合はレンダリングの必要はないですが、phrase.stateを更新しておらず"WAITING_TO_BE_RENDERED"のままになってしまっていたので、"PLAYABLE"に設定するようにしました。
sigprogramming
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
レンダリングの必要はないのに
stateがWAITING_TO_BE_RENDEREDのままになっているフレーズが存在してエラーになっていたので、修正します。その他
たぶん d3904c4 からバグってます。