Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CalendarRange): update calendar range select logic #7682

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас выбор промежутка дат в CalendarRange выглядит и работает очень не очевидно для пользователя. Нужно поменять логику выбора даты на более понятную. В кратце, необходимо третьим кликом на дату сбрасывать выбранный промежуток и давать пользователю выбрать новый промежуток

Изменения

  • Доработал логику выбора даты в CalendarRange
  • Поправил и добавил unit тесты для нового поведения

Release notes

Улучшения

  • CalendarRange: изменена логика выбора промежутка дат, теперь для сброса промежутка надо кликнуть на третью дату и можно выбрать новую дату

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner September 30, 2024 12:58
Copy link
Contributor

github-actions bot commented Sep 30, 2024

size-limit report 📦

Path Size
JS 385.43 KB (+0.01% 🔺)
JS (gzip) 116.66 KB (+0.03% 🔺)
JS (brotli) 95.75 KB (-0.1% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.29 KB (0%)
CSS (gzip) 41.52 KB (0%)
CSS (brotli) 32.94 KB (0%)

Copy link

codesandbox-ci bot commented Sep 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 29a9af4

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (60436ef) to head (d3d1a39).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7682      +/-   ##
==========================================
- Coverage   95.16%   95.15%   -0.01%     
==========================================
  Files         383      383              
  Lines       11335    11336       +1     
  Branches     3714     3715       +1     
==========================================
  Hits        10787    10787              
- Misses        548      549       +1     
Flag Coverage Δ
unittests 95.15% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Превосходно 👏 👏 👏

@inomdzhon inomdzhon merged commit f488210 into master Oct 1, 2024
27 of 28 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/7670/update-select-logic branch October 1, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]:CalendarRange изменить логику выбора диапазона дат
3 participants