Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: #7342 #7407

Merged
merged 1 commit into from
Aug 20, 2024
Merged

cherry-pick: #7342 #7407

merged 1 commit into from
Aug 20, 2024

Conversation

BlackySoul
Copy link
Contributor

* feat(ImageBase): remove position: absolute & add docs example with keepAspectRatio

* fix: remove useless internal variable
@BlackySoul BlackySoul requested a review from a team as a code owner August 20, 2024 05:30
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 20, 2024
@BlackySoul BlackySoul changed the title fix(ImageBase): remove position: absolute & update docs example (#7342) cherry-pick: #7342 Aug 20, 2024
@BlackySoul BlackySoul removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 20, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 377.54 KB (0%)
JS (gzip) 114.48 KB (0%)
JS (brotli) 93.93 KB (0%)
JS import Div (tree shaking) 1.39 KB (0%)
CSS 305.38 KB (-0.04% 🔽)
CSS (gzip) 39.18 KB (-0.05% 🔽)
CSS (brotli) 31.43 KB (-0.06% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 830137f

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (b965342) to head (830137f).
Report is 5 commits behind head on 6.5-stable.

Additional details and impacted files
@@             Coverage Diff             @@
##           6.5-stable    #7407   +/-   ##
===========================================
  Coverage       84.05%   84.05%           
===========================================
  Files             374      374           
  Lines           11092    11092           
  Branches         3639     3639           
===========================================
  Hits             9323     9323           
  Misses           1769     1769           
Flag Coverage Δ
unittests 84.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul merged commit cdca250 into 6.5-stable Aug 20, 2024
26 checks passed
@BlackySoul BlackySoul deleted the patch/pr7342 branch August 20, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants