feat(ImageBase): remove position: absolute & update docs example #7342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 64f2991 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7342 +/- ##
==========================================
+ Coverage 88.75% 92.54% +3.78%
==========================================
Files 374 374
Lines 11108 11118 +10
Branches 3640 3646 +6
==========================================
+ Hits 9859 10289 +430
+ Misses 1249 829 -420
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
previously approved these changes
Aug 8, 2024
inomdzhon
previously approved these changes
Aug 9, 2024
inomdzhon
approved these changes
Aug 19, 2024
BlackySoul
added a commit
that referenced
this pull request
Aug 20, 2024
* feat(ImageBase): remove position: absolute & add docs example with keepAspectRatio * fix: remove useless internal variable
Merged
BlackySoul
added a commit
that referenced
this pull request
Aug 20, 2024
…) (#7407) * feat(ImageBase): remove position: absolute & add docs example with keepAspectRatio * fix: remove useless internal variable
| ✅ v6.5.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас
keepAspectRatioуImageтребует явного задания ширины/высоты родителя, потому что непосредственно сама картинка имеетposition: absolute(соответственно, без явных указаний размеров картинка будет схлапываться или переполнять родительский контейнер). Также есть проблемы с обводкой - она не растягивается на размерам картинки.Изменения
Убираем
position: absoluteуimg