Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Spinner): remove auto-converting aria-label #6167

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

eugpoloz
Copy link
Contributor


Описание

Растаскиваю на части #6139, чтобы было попроще ревьюить.

Изменения

  • PullToRefresh: добавила метки доступности, пошуршала aria-label
  • Spinner: убрала приведение aria-label к children

Copy link
Contributor

size-limit report 📦

Path Size
JS 337.08 KB (+0.01% 🔺)
JS (gzip) 103.14 KB (+0.02% 🔺)
JS (brotli) 85.03 KB (+0.07% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 260.07 KB (0%)
CSS (gzip) 33.84 KB (0%)
CSS (brotli) 27.42 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a940ffe:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit a940ffe

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1831867) 79.99% compared to head (a940ffe) 80.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6167   +/-   ##
=======================================
  Coverage   79.99%   80.00%           
=======================================
  Files         311      311           
  Lines        9784     9787    +3     
  Branches     3285     3286    +1     
=======================================
+ Hits         7827     7830    +3     
  Misses       1957     1957           
Flag Coverage Δ
unittests 80.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@eugpoloz eugpoloz merged commit ca74678 into master Nov 30, 2023
26 checks passed
@eugpoloz eugpoloz deleted the eugpoloz/aria-label-Spinner branch November 30, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants