-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Spinner): remove auto-converting aria-label #6167
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a940ffe:
|
e2e tests
|
👀 Docs deployed
Commit a940ffe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6167 +/- ##
=======================================
Coverage 79.99% 80.00%
=======================================
Files 311 311
Lines 9784 9787 +3
Branches 3285 3286 +1
=======================================
+ Hits 7827 7830 +3
Misses 1957 1957
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
aria-label
в пользу скрытого визуально текста #2673Описание
Растаскиваю на части #6139, чтобы было попроще ревьюить.
Изменения
PullToRefresh
: добавила метки доступности, пошуршалаaria-label
Spinner
: убрала приведениеaria-label
кchildren