Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] refactor: Избавляемся от aria-label в пользу визуально скрытого текста #6139

Merged
merged 14 commits into from
Dec 5, 2023

Conversation

eugpoloz
Copy link
Contributor

@eugpoloz eugpoloz commented Nov 26, 2023


Описание

Отдельные пуллы в рамках этого:

Что осталось тут:

  • экспортировала VisuallyHiddenProps

  • убрала остатки использования и удалила getTitleFromChildren()

  • убрала aria-label и добавила скрытый текст:

    • Calendar — частично, не во всех местах получилось это удачно сделать; также переименовала пропсы
    • CellDragger
    • WriteBarIcon
    • PanelHeaderButton и его вариаций
    • ModalDismissButton и ModalCardBaseCloseButton
    • ScrollArrow
    • Pagination — также переименовала пропсы
    • Search — также переименовала пропсы
  • добавила документацию (relates to [Doc] Добавить в документации отдельных компонентов пункты о доступности #3035) и обновила примеры для:

    • ModalCardBase
    • ModalDismissButton
    • PanelHeaderButton
    • WriteBarIcon
    • TabbarItem

@eugpoloz eugpoloz changed the title [Breaking Change] refactor: Избавляемся от aria-label в пользу визуально скрытого текста [BREAKING CHANGE] refactor: Избавляемся от aria-label в пользу визуально скрытого текста Nov 26, 2023
Copy link
Contributor

github-actions bot commented Nov 26, 2023

size-limit report 📦

Path Size
JS 344.34 KB (+0.27% 🔺)
JS (gzip) 105.65 KB (+0.31% 🔺)
JS (brotli) 86.88 KB (+0.16% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 259.68 KB (0%)
CSS (gzip) 33.9 KB (0%)
CSS (brotli) 27.49 KB (0%)

Copy link

codesandbox-ci bot commented Nov 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f43fba4:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

github-actions bot commented Nov 26, 2023

e2e tests

Playwright Report

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (aa53bfc) 81.01% compared to head (f43fba4) 81.06%.
Report is 1 commits behind head on master.

Files Patch % Lines
...components/PanelHeaderButton/PanelHeaderButton.tsx 50.00% 2 Missing ⚠️
...ckages/vkui/src/components/DateInput/DateInput.tsx 90.90% 1 Missing ⚠️
...i/src/components/DateRangeInput/DateRangeInput.tsx 93.75% 1 Missing ⚠️
...ponents/ModalCardBase/ModalCardBaseCloseButton.tsx 75.00% 1 Missing ⚠️
...Pagination/PaginationPage/PaginationPageButton.tsx 66.66% 1 Missing ⚠️
...src/components/PanelHeaderEdit/PanelHeaderEdit.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6139      +/-   ##
==========================================
+ Coverage   81.01%   81.06%   +0.04%     
==========================================
  Files         317      316       -1     
  Lines        9890     9916      +26     
  Branches     3306     3327      +21     
==========================================
+ Hits         8012     8038      +26     
  Misses       1878     1878              
Flag Coverage Δ
unittests 81.06% <93.57%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eugpoloz eugpoloz force-pushed the eugpoloz/2673-aria-label-replacement branch from a013146 to dcb7057 Compare November 28, 2023 20:58
Copy link
Contributor

github-actions bot commented Nov 28, 2023

👀 Docs deployed

Commit f43fba4

@eugpoloz eugpoloz force-pushed the eugpoloz/2673-aria-label-replacement branch from dcb7057 to 1c83940 Compare November 30, 2023 02:40
@eugpoloz eugpoloz force-pushed the eugpoloz/2673-aria-label-replacement branch 5 times, most recently from c980f0c to 6fdde96 Compare December 4, 2023 04:02
@eugpoloz eugpoloz mentioned this pull request Dec 4, 2023
6 tasks
@eugpoloz eugpoloz force-pushed the eugpoloz/2673-aria-label-replacement branch 6 times, most recently from 7896781 to ccfc288 Compare December 4, 2023 19:19
@eugpoloz eugpoloz force-pushed the eugpoloz/2673-aria-label-replacement branch 2 times, most recently from f2b3fe2 to d0a70c6 Compare December 5, 2023 07:30
@eugpoloz eugpoloz force-pushed the eugpoloz/2673-aria-label-replacement branch from d0a70c6 to 8cac8b5 Compare December 5, 2023 07:41
@eugpoloz eugpoloz marked this pull request as ready for review December 5, 2023 07:45
@eugpoloz eugpoloz requested a review from a team as a code owner December 5, 2023 07:45
SevereCloud
SevereCloud previously approved these changes Dec 5, 2023
@VKCOM VKCOM deleted a comment from eugpoloz Dec 5, 2023
inomdzhon
inomdzhon previously approved these changes Dec 5, 2023
mendrew
mendrew previously approved these changes Dec 5, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отличная работа! 💪

packages/vkui/src/components/WriteBarIcon/WriteBarIcon.tsx Outdated Show resolved Hide resolved
@eugpoloz eugpoloz dismissed stale reviews from mendrew, inomdzhon, and SevereCloud via f43fba4 December 5, 2023 09:54
@eugpoloz eugpoloz requested a review from mendrew December 5, 2023 10:03
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@eugpoloz eugpoloz merged commit 6e5a521 into master Dec 5, 2023
25 checks passed
@eugpoloz eugpoloz deleted the eugpoloz/2673-aria-label-replacement branch December 5, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][a11y] Отойти от aria-label в пользу скрытого визуально текста
4 participants