-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING CHANGE] refactor: Избавляемся от aria-label
в пользу визуально скрытого текста
#6139
Conversation
aria-label
в пользу визуально скрытого текстаaria-label
в пользу визуально скрытого текста
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f43fba4:
|
e2e tests |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6139 +/- ##
==========================================
+ Coverage 81.01% 81.06% +0.04%
==========================================
Files 317 316 -1
Lines 9890 9916 +26
Branches 3306 3327 +21
==========================================
+ Hits 8012 8038 +26
Misses 1878 1878
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a013146
to
dcb7057
Compare
👀 Docs deployed
Commit f43fba4 |
dcb7057
to
1c83940
Compare
c980f0c
to
6fdde96
Compare
7896781
to
ccfc288
Compare
& update docs
and get rid of most aria-labels
and default labels
& use visually hidden text
f2b3fe2
to
d0a70c6
Compare
d0a70c6
to
8cac8b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Отличная работа! 💪
f43fba4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
aria-label
в пользу скрытого визуально текста #2673aria-label
в пользу визуально скрытого текста #6139 (comment)Описание
Отдельные пуллы в рамках этого:
getTextFromChildren()
(lib/children utils) #6138aria-label
via children #6168label
prop #6190Что осталось тут:
экспортировала
VisuallyHiddenProps
убрала остатки использования и удалила
getTitleFromChildren()
убрала
aria-label
и добавила скрытый текст:Calendar
— частично, не во всех местах получилось это удачно сделать; также переименовала пропсыCellDragger
WriteBarIcon
PanelHeaderButton
и его вариацийModalDismissButton
иModalCardBaseCloseButton
ScrollArrow
Pagination
— также переименовала пропсыSearch
— также переименовала пропсыдобавила документацию (relates to [Doc] Добавить в документации отдельных компонентов пункты о доступности #3035) и обновила примеры для:
ModalCardBase
ModalDismissButton
PanelHeaderButton
WriteBarIcon
TabbarItem