-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Form): добавляем новый компонент Form на замену FormLayout #4576
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e6dbe3e:
|
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4576 +/- ##
=======================================
Coverage 81.66% 81.67%
=======================================
Files 278 279 +1
Lines 8679 8693 +14
Branches 2963 2968 +5
=======================================
+ Hits 7088 7100 +12
- Misses 1591 1593 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4576/ |
12fcb02
to
abb5669
Compare
abb5669
to
4bb5df6
Compare
4bb5df6
to
7309b09
Compare
7309b09
to
e72fa37
Compare
to replace FormLayout
fix wordings
fix wordings
add submit buttons, fix wordings
add information about submit button to be absolutely clear
b349469
to
e6dbe3e
Compare
👀 Docs deployedCommit e6dbe3e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Может нам и не нужен компонент Form
? Ведь формы это уже что-то посложнее и от проекта к проекту отличаются
С нашей стороны мы отдаём FormLayoutGroup
, который помогает настроить визуальную часть, а всё остальное уже не задача ui кита
Пользователь сам своей стороне оборачивает в <form>
или использует готовую библиотеку для работы с формами (например, react-final-form
)
И вот задепрейкить FormLayout
точно надо 👍
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
Описание из связанной задачи:
Что сделала:
Form
без скрытого инпутаFormLayout
наForm
FormLayout
FormLayout
#4004