Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement][a11y] Улучшить доступность FormLayout #4004

Closed
eugpoloz opened this issue Jan 16, 2023 · 2 comments · Fixed by #6302
Closed

[Enhancement][a11y] Улучшить доступность FormLayout #4004

eugpoloz opened this issue Jan 16, 2023 · 2 comments · Fixed by #6302
Assignees
@BlackySoul
Labels
a11y Доступность (цифровая) cmp:form-layout type:enhancement v6.0.0-beta.2
Milestone
v6.0.0

Comments

@eugpoloz
Copy link
Contributor

eugpoloz commented Jan 16, 2023 •
edited
Loading

История задачи:

Сначала мы хотели добавить доступность скрытой кнопке сабмита внутри FormLayout (см. #4005).

Потом пришли к выводу, что скрытой кнопки не должно быть вообще — в форме всегда должна быть какая-то очевидная и доступная всем кнопка с type="submit". В итоге решили, что лучше всего будет сделать новый компонент, а старый задепрекейтить.
@eugpoloz eugpoloz added type:enhancement a11y Доступность (цифровая) cmp:form-layout labels Jan 16, 2023
@eugpoloz eugpoloz self-assigned this Jan 16, 2023
@eugpoloz eugpoloz added this to VKUI Jan 16, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Jan 16, 2023
@eugpoloz eugpoloz moved this from 🗃 Backlog to 🔧 In progress in VKUI Jan 16, 2023
@eugpoloz eugpoloz mentioned this issue Jan 16, 2023
Closed
@eugpoloz eugpoloz moved this from 🔧 In progress to 👀 In Review in VKUI Jan 16, 2023
@eugpoloz eugpoloz moved this from 👀 In Review to 🔧 In progress in VKUI Feb 6, 2023
@eugpoloz eugpoloz mentioned this issue Mar 23, 2023
Closed
5 tasks
@eugpoloz eugpoloz moved this from 🔧 In progress to 👀 In Review in VKUI Mar 31, 2023
@inomdzhon
Copy link
Contributor

Прикладываю коммент из PR сюда #4576 (comment)

@eugpoloz eugpoloz moved this from 👀 In Review to 🔜 To do in VKUI Jul 18, 2023
@BlackySoul BlackySoul mentioned this issue Dec 18, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🔜 To do to ✅ Done in VKUI Dec 19, 2023
@inomdzhon inomdzhon added this to the v6 milestone Dec 20, 2023
@inomdzhon inomdzhon assigned BlackySoul and unassigned eugpoloz Dec 20, 2023
@vkcom-publisher
Copy link
Contributor

✅ v6.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BlackySoul BlackySoul

Labels
a11y Доступность (цифровая) cmp:form-layout type:enhancement v6.0.0-beta.2
Projects
VKUI
Archived in project
Milestone
v6.0.0
4 participants
@inomdzhon @BlackySoul @eugpoloz @vkcom-publisher