Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary solution for ignoring unhandled exceptions that have been handled via exception event listener. #273

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Temporary solution for ignoring unhandled exceptions that have been handled via exception event listener. #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/coreclr/vm/excep.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4767,7 +4767,8 @@ LONG InternalUnhandledExceptionFilter_Worker(
#endif // !TARGET_UNIX

// Send notifications to the AppDomains.
NotifyAppDomainsOfUnhandledException(pParam->pExceptionInfo, NULL, useLastThrownObject, fIsProcessTerminating /*isTerminating*/);
// UNITY: We'll assume for now that if an event is sent that the unhandled exception has been handled until the proposed API: https://github.com/dotnet/runtime/issues/101560 has been implemented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to control this via an exported function or some other mechanism?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could... I figure if we wanted the exception to be fatal we could always terminate from the handler?

fIsProcessTerminating = !NotifyAppDomainsOfUnhandledException(pParam->pExceptionInfo, NULL, useLastThrownObject, fIsProcessTerminating /*isTerminating*/);

// If the process is not terminating, then return back to the filter and ask it to execute
if (!fIsProcessTerminating)
Expand Down