Temporary solution for ignoring unhandled exceptions that have been handled via exception event listener. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andled via exception event listener.
joncham
reviewed
Nov 6, 2024
| @@ -4767,7 +4767,8 @@ LONG InternalUnhandledExceptionFilter_Worker( | |||
| #endif // !TARGET_UNIX | |||
|
|
|||
| // Send notifications to the AppDomains. | |||
| NotifyAppDomainsOfUnhandledException(pParam->pExceptionInfo, NULL, useLastThrownObject, fIsProcessTerminating /*isTerminating*/); | |||
| // UNITY: We'll assume for now that if an event is sent that the unhandled exception has been handled until the proposed API: https://github.com/dotnet/runtime/issues/101560 has been implemented | |||
There was a problem hiding this comment.
Do we want to control this via an exported function or some other mechanism?
There was a problem hiding this comment.
We could... I figure if we wanted the exception to be fatal we could always terminate from the handler?
joncham
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of the UhandledExceptionListener:
AppDomain.CurrentDomain.UnhandledExceptionAdding an UnhandledEvent listener will now change the default behavior of UnhandledExceptions to no longer be fatal. This is a temporary solution until the upstream API proposal: dotnet#101560 has been implemented.