fix: NetworkRigidbody2D not changing body type with authority [MTT-8510] #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realized we needed an overhaul with our rigid body tests so I did a bit of refactoring. Added temporary internal method, OnSetupRigidbody, to both network rigid body components and will circle back to this test once the prespawn PR is merged to replace it with the NetworkBehaviour.OnNetworkPreSpawn. Deleted the remaining of the completely commented out rigid body tests that are now being covered in the NetworkRigidbodyTests.
NoelStephensUnity
requested review from
chrispope,
miniwolf and
a team
as code owners
NoelStephensUnity
changed the title
…ype-with-authority
NoelStephensUnity
deleted the
fix/networkrigidbody2d-not-changing-bodytype-with-authority
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue with NetworkRigidbody2D not changing the Rigidbody2D body type with a change in authority.
(does not require up-port to v2.0.0 as this issue is already fixed with the updated NetworkRigidbodyBase)
MTT-8510
fix: #2915
Changelog
NetworkRigidbody2Dwould not properly change body type based on the instance's authority when spawned.Testing and Documentation