Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydantic alias for serialization of BGP/BFD events #335

Merged

Conversation

johannaengland
Copy link
Contributor

Scope and purpose

Fixes #331.

This pull request

  • changes the API

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

@johannaengland johannaengland added bug Something isn't working api labels Jul 31, 2024
@johannaengland johannaengland self-assigned this Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (920b82b) to head (e5770b8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          64       64           
  Lines        7920     7922    +2     
=======================================
+ Hits         7708     7710    +2     
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Contributor

@stveit stveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the "_" to "-" conversion becomes redundant once all of the necessary aliases are added

@johannaengland
Copy link
Contributor Author

I suppose the "_" to "-" conversion becomes redundant once all of the necessary aliases are added

Yes, but I am not sure if these aliases are all that are needed to be able to remove that conversion. So I'll keep it for now, but I'll add an issue for discussion

@johannaengland johannaengland merged commit db973bf into Uninett:master Aug 1, 2024
9 of 10 checks passed
@johannaengland johannaengland deleted the bugfix/upper-case-parameters branch August 1, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zino1 protocol: parameter case-sensitive inconsistencies with tcl implementation
3 participants