Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zino1 protocol: parameter case-sensitive inconsistencies with tcl implementation #331

Closed
runborg opened this issue Jul 30, 2024 · 2 comments · Fixed by #335
Closed

zino1 protocol: parameter case-sensitive inconsistencies with tcl implementation #331

runborg opened this issue Jul 30, 2024 · 2 comments · Fixed by #335
Assignees
Labels
bug Something isn't working

Comments

@runborg
Copy link

runborg commented Jul 30, 2024

In the original zino implementation there are a few parameters that use upper-case characters in their names.
Zino2 does not take this into account and only uses lowercase parameter names

This makes the original x11 ritz client crash because it is case-sensitive on its parameter names.
This is identified for the following parameters:
BGP:

  • bgpAS
  • bgpOS
  • remote-AS

BFD:

  • Neigh-rDNS
  • bfdAddr
  • bfdDiscr
  • bfdIx
  • bfdState
@runborg runborg changed the title zino1 protocol parameter case-sensitive inconsistencies with tcl implementation zino1 protocol: parameter case-sensitive inconsistencies with tcl implementation Jul 30, 2024
@johannaengland johannaengland added the bug Something isn't working label Jul 31, 2024
@johannaengland johannaengland self-assigned this Jul 31, 2024
@runborg
Copy link
Author

runborg commented Aug 1, 2024

PR #335 is tested with the x11 tcl ritz client and seems to work fine

@lunkwill42
Copy link
Member

This is related to #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants