Fix PhantomJS test problems #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures we use the same Node version as our docker test image.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 14s ⏱️ Results for commit 2ef65c3. ♻️ This comment has been updated with latest results. |
PhantomJS is outdated and tries to use parts of OpenSSL that are no longer there. We shouldn't need SSL for the JS tests, so this attempts to disable it temporarily during the test run.
lunkwill42
force-pushed
the
test/phantomjs-ci-problems
branch
from
e8443cc to
2ef65c3
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3142 +/- ##
=======================================
Coverage 60.44% 60.44%
=======================================
Files 605 605
Lines 43749 43749
Branches 48 48
=======================================
Hits 26443 26443
Misses 17294 17294
Partials 12 12 ☔ View full report in Codecov by Sentry. |
podliashanyk
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Nice! Have also created an issue regarding removing PhantomJS: #3143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhantomJS development has ceased. Our CI test suite currently fails because the outdated version of PhantomJS we're using for the JS tests is trying to use OpenSSL features that are no longer present in more recent versions of OpenSSL:
This PR fixes the problem by temporarily disabling OpenSSL during the running of the test suite on GitHub actions (specifically). The test suite still runs fine on the Docker test image supplied with NAV, since it is based on a slightly older Ubuntu.
For good measure, the PR also updates the workflow to use Node 18, just as the Docker image does.
The future of PhantomJS
We should consider removing PhantomJS from our test suite entirely. It is debatable whether is serves any purpose, since we also test on real JS engines like Firefox and Chrome.