Uncrispyfy NavbarlinkForm and NavbarLinkFormSet #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 8 files 8 suites 8m 26s ⏱️ Results for commit 81d632a. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3139 +/- ##
==========================================
- Coverage 60.44% 60.43% -0.01%
==========================================
Files 605 605
Lines 43749 43745 -4
Branches 48 48
==========================================
- Hits 26443 26439 -4
Misses 17294 17294
Partials 12 12 ☔ View full report in Codecov by Sentry. |
lunkwill42
requested changes
Oct 15, 2024
|
Also, I guess the tests won't properly pass until #3142 is merged... |
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3099, #3107
http://localhost/preferences/ under 'My stuff' quick links
Difference from the original implementation: the
hiddeninput in each form became a part of the<row>. Functionally and visually it bears no difference whatsoever, yet simplifies the form template considerably.