Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backwards relation references in group search #2596

Conversation

johannaengland
Copy link
Contributor

When writing a test for the bug that will be fixed in #2595 I also realized that something similar happened in device group search. This PR fixes that.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #2596 (ceb3321) into master (e544ba1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head ceb3321 differs from pull request most recent head 93df6c3. Consider uploading reports for the commit 93df6c3 to get more accurate results

@@            Coverage Diff             @@
##           master    #2596      +/-   ##
==========================================
- Coverage   54.20%   54.19%   -0.01%     
==========================================
  Files         558      558              
  Lines       40627    40626       -1     
==========================================
- Hits        22020    22018       -2     
- Misses      18607    18608       +1     
Impacted Files Coverage Δ
python/nav/web/info/netboxgroup/views.py 28.81% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 21, 2023

Test results

     12 files       12 suites   11m 24s ⏱️
3 233 tests 3 137 ✔️   96 💤 0
9 174 runs  8 886 ✔️ 288 💤 0

Results for commit ceb3321.

♻️ This comment has been updated with latest results.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johannaengland johannaengland force-pushed the bugfix/device-group-search-related-names branch from ceb3321 to 93df6c3 Compare March 31, 2023 12:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johannaengland johannaengland merged commit 72a94db into Uninett:master Mar 31, 2023
@johannaengland johannaengland deleted the bugfix/device-group-search-related-names branch March 31, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants