-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backwards relation references in room search #2595
Fix backwards relation references in room search #2595
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
==========================================
- Coverage 54.20% 54.05% -0.16%
==========================================
Files 558 558
Lines 40634 40602 -32
==========================================
- Hits 22026 21946 -80
- Misses 18608 18656 +48
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes are good, but I'm not sure I see the point of the changelog entry...
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since what this fixes was never released I am guessing what @lunkwill42 means is that the changelog is not necessary at all. Or did you mean something else?
I mean exactly what it says in the ensuing discussion under the "Outdated" review item, @hmpf :) |
17ef4e0 broke things by adding a related name that was used otherwise
c47e62b
to
50de7f0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
17ef4e0 broke things by adding a related name that was used otherwise (netboxes) and me changing
location
tochild_locations
, where it was actually incorrect, which resulted in the room search not working.Luckily I caught this before it was included in a release.