Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip-compile's backtracking dependency resolver to fix failing CI pipelines #2509

Merged

Conversation

lunkwill42
Copy link
Member

The CI pipeline began failing three days ago, due some dependency changes in an upstream dependency.

It seems the pip-compile step of our tox environments became unable to resolve a full dependency graph from this point on (related to versions of pylint, it seems).

Using the backtracking resolver of pip-compile allows it to select older dependencies as long our pinned requirements are satisfied.

The CI pipeline began failing three days ago, due some dependency
changes in an upstream dependency.

It seems the pip-compile step of our tox environments became unable to
resolve a full dependency graph from this point on (related to versions
of pylint, it seems).

Using the backtracking resolver of pip-compile allows it to select older
dependencies as long our pinned requirements are satisfied.
@lunkwill42 lunkwill42 self-assigned this Nov 22, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #2509 (dd75aec) into 5.5.x (a1268fb) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            5.5.x    #2509      +/-   ##
==========================================
- Coverage   53.05%   53.02%   -0.04%     
==========================================
  Files         554      554              
  Lines       40292    40292              
==========================================
- Hits        21376    21363      -13     
- Misses      18916    18929      +13     
Impacted Files Coverage Δ
python/nav/ipdevpoll/pool.py 84.88% <0.00%> (-5.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Test results

     12 files       12 suites   11m 21s ⏱️
3 096 tests 3 000 ✔️   96 💤 0
8 763 runs  8 475 ✔️ 288 💤 0

Results for commit dd75aec.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stveit
Copy link
Contributor

stveit commented Nov 22, 2022

yes pls 👍

@lunkwill42 lunkwill42 merged commit 34c78b1 into Uninett:5.5.x Nov 22, 2022
@lunkwill42 lunkwill42 deleted the test/backtracking-dependency-resolver branch November 22, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants