Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade napalm to 4.0.0 #2508

Closed
wants to merge 1 commit into from

Conversation

johannaengland
Copy link
Contributor

Fixes the tests not running due to incompatible dependencies.

Release notes from napalm: https://github.com/napalm-automation/napalm/releases

@johannaengland johannaengland added the dependencies Pull requests that update a dependency file label Nov 22, 2022
@johannaengland johannaengland self-assigned this Nov 22, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #2508 (b43bd68) into master (aa35e2a) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2508      +/-   ##
==========================================
+ Coverage   53.02%   53.05%   +0.03%     
==========================================
  Files         554      554              
  Lines       40292    40292              
==========================================
+ Hits        21363    21376      +13     
+ Misses      18929    18916      -13     
Impacted Files Coverage Δ
python/nav/ipdevpoll/pool.py 89.92% <0.00%> (+5.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the exact nature of the failing tests? Upgrading napalm to the next major version seems an awfully big step to just try getting tests to pass.

Testing on master now, I don't have any failing tests - rather, I'm unable to have pip-compile build a complete requirements manifest, because of some third party dependency changes. It seems to be easily resolved by employing the backtracking dependency resolver of pip-compile (i.e. the "normal" mode doesn't actually allow for installing older versions of any dependencies to make the whole manifest compatible).

@github-actions
Copy link

Test results

     12 files       12 suites   11m 30s ⏱️
3 096 tests 3 000 ✔️   96 💤 0
8 763 runs  8 475 ✔️ 288 💤 0

Results for commit b43bd68.

@lunkwill42
Copy link
Member

I've submitted #2509 as an alternative to this. I do not like upgrading to a new major version of a dependency when our code hasn't changed - and I'm not confident we have automated tests that will cover any compatibility problems with a new major version of napalm.

@johannaengland johannaengland deleted the upgrade-napalm branch November 22, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants