Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python versions #450

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Update Python versions #450

merged 6 commits into from
Nov 18, 2021

Conversation

dopplershift
Copy link
Member

@dopplershift dopplershift commented Nov 17, 2021 •
edited
Loading

Description Of Changes

Checklist

@dopplershift dopplershift force-pushed the python-versions branch 2 times, most recently from 77ece59 to 7a7c4be Compare November 18, 2021 05:30
@dopplershift
MNT: Update code for Python 3
3316bb6 
Found with pyupgrade 2.29.1
dcamron
dcamron previously approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all just linting, which we can spare for some other style cleanup if preferred. I'll approve and leave that call up to you

src/siphon/cdmr/ncstream.py Show resolved Hide resolved
src/siphon/metadata.py Outdated Show resolved Hide resolved
src/siphon/ncss_dataset.py Outdated Show resolved Hide resolved
@dopplershift
Copy link
Member Author

Thanks for catching those. I just added the logging changes as a separate commit, so re-review should be simple.

@dopplershift
MNT: Improve some logging calls
fa1e927 
Don't unconditionally do the string interpolation, but rather let
logging do it if it's enabled.
@dopplershift
Copy link
Member Author

CodeQL is succeeding, but for some reason is failing to report. 🤷‍♂️

@dopplershift dopplershift merged commit 1e334ee into Unidata:master Nov 18, 2021
@dopplershift dopplershift deleted the python-versions branch November 18, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcamron dcamron dcamron approved these changes

@lesserwhirls lesserwhirls Awaiting requested review from lesserwhirls lesserwhirls is a code owner

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropping support for Python 2.7
2 participants
@dopplershift @dcamron