MNT: Improve some logging calls

Don't unconditionally do the string interpolation, but rather let logging do it if it's enabled.
Unidata · Nov 18, 2021 · fa1e927 · fa1e927
1 parent 3316bb6
commit fa1e927
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/siphon/metadata.py b/src/siphon/metadata.py
@@ -511,8 +511,7 @@ def _get_handler(self, handler_name):
         elif handler_name in self._sts:
             return getattr(self._st, handler_name)
         else:
-            msg = f'cannot find handler for element {handler_name}'
-            log.warning(msg)
+            log.warning('cannot find handler for element %s', handler_name)
 
     def _parse_element(self, element):
 

diff --git a/src/siphon/ncss_dataset.py b/src/siphon/ncss_dataset.py
@@ -200,8 +200,7 @@ def lookup(self, handler_name):
         if handler_name in dir(self):
             return getattr(self, handler_name)
         else:
-            msg = f'cannot find handler for element {handler_name}'
-            log.warning(msg)
+            log.warning('cannot find handler for element %s', handler_name)
 
 
 class NCSSDataset: