Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Libsamplerate Audio Converter #943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

complexlogic
Copy link

Fixes #942

@barbeque-squared
Copy link
Member

Started builds. I'll do a more in-depth review (at a first glance it looks fine) and run the application on a few platforms later today. If that also passes, expect this to be merged today.

Copy link
Member

@barbeque-squared barbeque-squared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks and works fine (the diff of config-win.inc really says it all...). When grepping through the code I did find that src/lib/lib-info.txt still has some text about samplerate around line 51.

That file is most probably not reflective of the libs directory (it's the first time I even see this file) but just remove the samplerate section from it and this PR can get merged.

(I'm scared to find out some of the stuff that txt mentions. Especially where it says 'slightly patched', or it's referencing things deleted 9 years ago, or the one that simply says "not used anymore" yet the library code is still there...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status of Libsamplerate Audio Converter
2 participants