Status of Libsamplerate Audio Converter

[complexlogic]

I'm looking through the source code, and noticed the libsamplerate/SRCresampler TAudioconverter implementation. Its usage in the code is controlled by the definitions UseSRCResample and HaveLibsamplerate, which are never defined by the build system. See here.

Is this still needed, or can it be removed?

[barbeque-squared]

It's probably a leftover from when something was not completely removed somewhere before 2016 (or never fully implemented to begin with). Easiest thing to do is probably just delete it, open a PR for it and see if anything breaks in the CI (it builds all platforms).

If all jobs pass, for things like this I'll then grab the portable and see if that still works on my Windows, and build + run it on my Linux machine. If nothing appears to be immediately broken, it gets merged. This doesn't need to take long, can be as fast as within a day.

The code you're working with is probably even older than the theme/drawing stuff I'm slowly refactoring, and I've already seen functions that were never called or just duplicates.