Clarify "has access" in study site member table #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of "has_access", use "In members group?". This can be done dynamically in the view where this table is being used. Also update some language on the StudySiteDetail page for clarify.
Because the UserAccountSingleGroupMembershipTable table is now being used more broadly, coding the verbose name to "has access" is no longer appropriate. Do not a specify a verbose name, and instead set the name dynamically if it should be different (e.g., when used in the cdsa and dbgap apps).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 325 325
Lines 30550 30563 +13
=======================================
+ Hits 30248 30261 +13
Misses 302 302 ☔ View full report in Codecov by Sentry. |
amstilp
deleted the
feature/clarify-has-access-in-study-site-member-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_group_membercolumn fromUserAccountSingleGroupMembershipTableCloses #673