Fix failing test for mysql #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_dbgap_project_id_does_not_match was failing only in mysql likely because in mysql tests, the pk field does not reset to 1 for each test. A (new) previous test likely created a dbGaP application, so when this test had the project_id hard-coded, it failed. Now, set the dbGaP application project_id using the application that the test created in the setup method.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 325 325
Lines 30411 30411
=======================================
Hits 30109 30109
Misses 302 302 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_dbgap_project_id_does_not_match was failing only in mysql likely because in mysql tests, the pk field does not reset to 1 for each test. A (new) previous test likely created a dbGaP application, so when this test had the project_id hard-coded, it failed. Now, set the dbGaP application project_id using the application that the test created in the setup method.