Associate study sites with members groups #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amstilp
commented
Jul 10, 2024
amstilp
commented
- Link a StudySite with the corresponding members ManagedGroup on AnVIL
- Add a new table, UserAccountTable
- Show the list of member group members on the StudySiteDetail view.
- If the study site member group is set, show the UserAccountSingleGroupMembershipTable on the StudySiteDetail view. Otherwise, show the UserAccountTable.
All (or at least most) Study Sites have a members group associated with them, and members's anvil accounts need to be added to that group so that they can get data access on AnVIL. The first step in making this more automated is to link a StudySite with its member group via a OneToOne field.
Include a link to the member group, if it exists. Also show a table Accoutns that are part of the member group (and therefore should have data access).
If member_group is set, use the UserAccountSingleGroupMembershipTable; otherwise, use a newly-defined table (UserAccountTable). This lets CC staff see who from the site has a) linked their account and b) been added to the member group (if it is set).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
========================================
Coverage 99.00% 99.00%
========================================
Files 323 325 +2
Lines 30248 30400 +152
========================================
+ Hits 29946 30098 +152
Misses 302 302 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.