Require numpy<2.0 #610
Merged
Require numpy<2.0 #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy 2.0 is breaking some things in the CI; will deal with it later.
…es/610 Update requirements file for maint/numpy-version
The latest version of pandas might also be causing issues when recompiling requirements files for python 3.12?
Can help debug issues.
This lets us see what pip-compile says with the -v flag.
Pandas 2.2.2 works with numpy 2.0 and previous versions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 300 300
Lines 23850 23850
=======================================
Hits 23549 23549
Misses 301 301 ☔ View full report in Codecov by Sentry. |
…es/610 Update requirements file for maint/numpy-version
It doesn't work in python 3.8.
We can't control these warnings. We only want the warnings raised by our code to convert to errors.
It wasn't working as hoped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy 2.0 is breaking some things in the CI; will deal with it later.