Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI step to optionally recompile requirements files with pip-sync #578

Merged
merged 5 commits into from
May 15, 2024

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented May 14, 2024

  • Add a step to the CI that (optionally) reruns pip-compile on the requirements.in files
  • Add a pip-recompile setting to the matrix definitions that can be used to toggle whether this step should run.

The pip-recompile setting can be set to true when we want to test future versions of python compared to what is running on the live servers.

In the first, upgrade pip and setuptools. Then install piptools.
Finally, install the dependencies with pip-sync.
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (391ab91) to head (4c4d8c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   98.71%   98.73%   +0.01%     
==========================================
  Files         300      300              
  Lines       23815    23815              
==========================================
+ Hits        23510    23514       +4     
+ Misses        305      301       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amstilp added 4 commits May 14, 2024 11:53
This setting can be used to test future python versions that are
not live on the servers yet.
We had issues compiling requirements files with python 3.12 in the
gregor-django repository, so I expect that it wont work here either.
python3.12 had the same error as in gregor-django.
@amstilp amstilp marked this pull request as ready for review May 15, 2024 21:57
@amstilp amstilp merged commit 106288f into main May 15, 2024
10 checks passed
@amstilp amstilp deleted the maint/optional-pip-compile-in-ci branch May 15, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant