Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell checker checking only committed files? #79

Closed
bclaremar opened this issue May 28, 2024 · 7 comments
Closed

Spell checker checking only committed files? #79

bclaremar opened this issue May 28, 2024 · 7 comments
Assignees

Comments

@bclaremar
Copy link
Contributor

No description provided.

@richelbilderbeek
Copy link
Member

I think this is possible. I will take a look :-)

@richelbilderbeek
Copy link
Member

Created an Issue at igsekor/pyspelling-any#8

@richelbilderbeek
Copy link
Member

I'll do so, no need to keep Björn assigned here :-)

@richelbilderbeek richelbilderbeek changed the title Spell checker checks whole site, possible to just check the committed files? Spell checker checking only committed files? May 30, 2024
@richelbilderbeek
Copy link
Member

Posted in Matrix:

Both me and @jayant-yadav think the spellcheck takes too long. A thing I do nowadays is to work on the develop branch, which only has short CI test. I merge to main when done (and then get a full-blown check). The spellcheck only runs on main and for Pull Requests 👍️

@richelbilderbeek
Copy link
Member

richelbilderbeek commented Sep 13, 2024

I feel it is good enough, but maybe @jayant-yadav wants to spend some time on this? The feature to only check changes has been suggested to the spellcheck author.

I will assign him, so he can close the Issue when he thinks it is fixed well enough too 👍

@paran1
Copy link

paran1 commented Oct 18, 2024

I saw this issue after I made PR #143

I noticed that spellchecking is spending almost all its time checking `perl.md. I have not dug into pyspelling to figure out what kind of horrible edge-case it triggers, instead I just exclude that file from spellchecking. Then I also change to use a more updated pyspelling github actuin, and some other things, check the PR.

If #143 is merged then I think this issue can be closed as we can run spellcheck on each push for all files (except perl.md) in less than 30 seconds.

@richelbilderbeek
Copy link
Member

@paran1 this is brilliant! Thanks 👍!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants