Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check files that have been changed? #8

Open
richelbilderbeek opened this issue May 29, 2024 · 2 comments
Open

Only check files that have been changed? #8

richelbilderbeek opened this issue May 29, 2024 · 2 comments

Comments

@richelbilderbeek
Copy link

Dear maintainer,

I enjoy this Action a lot and use it extensively. However, using v1.0.4 (instead of v0.02) makes the check take one or two orders of magnitude longer. Even that is fine: I guess it is doing a lot of thinking :-)

However, instead of extensively checking for all pages in a repo, I wonder if there is an option to check only the pages that have been changed.

I can imagine I missed that option somewhere! If I did, I hope this option will be added to the docs 👍

Thanks and cheers, Richel Bilderbeek

@igsekor
Copy link
Owner

igsekor commented Jul 21, 2024

Dear Richèl,

I'm so glad to see the interest to my repo. I was in vocation and couldn't answer briefly.

Thank you for your response and issue. I'll add all thinks in near future.

@richelbilderbeek
Copy link
Author

Hi @igsekor, that is great!

Note that this comment is false:

However, using v1.0.4 (instead of v0.02) makes the check take one or two orders of magnitude longer.

The two versions are more or less equally fast!

Additionally, I am unsure if doing a per-commit spell-check is a good idea at all. For example, what if someone commits 10x and pushes once: how would the Action know from which commit to check?

Maybe you have more/better ideas than me and/or you come up with a better reasoning why this is a bad idea: I'd be happy in any case!

Thanks already and cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants