Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/DIMSv2.6.0 TICplots to dev #80

Merged
merged 3 commits into from
Jan 4, 2024
Merged

release/DIMSv2.6.0 TICplots to dev #80

merged 3 commits into from
Jan 4, 2024

Conversation

mraves2
Copy link
Collaborator

@mraves2 mraves2 commented Dec 5, 2023

Added functionality to create TIC plots

  • Modified 2-DIMS.R to write out txt files with info for TIC plots
  • Modified 3-averageTechReplicates.R to collect txt files and generate PDF with TIC plots.
    Added functionality to display Z-score values in violin plots
  • Modified AddOnFunctions/create_violin_plots.R

BasMonkey
BasMonkey requested changes Dec 19, 2023
View reviewed changes
Copy link

@BasMonkey BasMonkey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on individual lines. I would also suggest to (re)name the branches a more descriptive name. Especially since this is not a release branch, but a feature into develop. E.g. give a pull request like this the name of the feature that is added.

BasMonkey
BasMonkey approved these changes Jan 4, 2024
View reviewed changes
Copy link

@BasMonkey BasMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok

@mraves2 mraves2 merged commit 48df27f into develop Jan 4, 2024
@ellendejong ellendejong changed the title release/DIMSv2.6.0 release/DIMSv2.6.0 feature/TICplots to dev Jan 10, 2024
@ellendejong ellendejong changed the title release/DIMSv2.6.0 feature/TICplots to dev release/DIMSv2.6.0 TICplots to dev Jan 10, 2024
@ellendejong ellendejong mentioned this pull request Jan 10, 2024
Merged
@mraves2 mraves2 deleted the feature/TICplots branch March 25, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BasMonkey BasMonkey BasMonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraves2 @BasMonkey