-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FN-3163): Create new DTFS exporters in Salesforce #4021
Open
natdeanlewissoftwire
wants to merge
69
commits into
feat/FN-3163/create-new-dtfs-customers-in-sf
Choose a base branch
from
feat/FN-3163/create-new-dtfs-customer-in-sf-informatica
base: feat/FN-3163/create-new-dtfs-customers-in-sf
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(FN-3163): Create new DTFS exporters in Salesforce #4021
natdeanlewissoftwire
wants to merge
69
commits into
feat/FN-3163/create-new-dtfs-customers-in-sf
from
feat/FN-3163/create-new-dtfs-customer-in-sf-informatica
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
December 3, 2024 13:02 — with
GitHub Actions
Inactive
natdeanlewissoftwire
changed the base branch from
main
to
feat/FN-3163/create-new-dtfs-customers-in-sf
December 3, 2024 14:05
natdeanlewissoftwire
changed the title
Feat/fn 3163/create new dtfs customer in sf informatica
feat(FN-3163): create new DTFScustomer in Salesforce
Dec 3, 2024
natdeanlewissoftwire
changed the title
feat(FN-3163): create new DTFScustomer in Salesforce
feat(FN-3163): create new DTFS customer in Salesforce
Dec 3, 2024
This was referenced Dec 3, 2024
natdeanlewissoftwire
changed the title
feat(FN-3163): create new DTFS customer in Salesforce
feat(FN-3163): Create new DTFS exporters in Salesforce
Dec 3, 2024
Quality Gate passedIssues Measures |
natdeanlewissoftwire
requested review from
abhi-markan,
ttbarnes and
ChristianMcc
December 9, 2024 09:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
As part of the CCM project, if a customer does not exist in Salesforce, we are automatically creating it rather than relying on the manual process currently undertaken by Business Support Group. This change sends a request to a new createParty endpoint that will be merged in to the MDM codebase.
Tech docs of the full process are available here
Resolution ✔️
Feature flagged for now:
Send a "get or create" request to APIM, which handles all the logic. The creation process involves querying Salesforce via Informatica, getting a DUNS number, generating a PartyURN or using a legacy one and then returning the created customer to DTFS so the URN can be assigned to the new deal in TFM.
Miscellaneous ➕
Increase the deal submission timeout to 30 seconds to allow this process to consistently succeed. This won't be necessary once the deal submission is handled by background processes as discussed in the root README.