feat(FN-3163): MDM endpoints for automatically creating new DTFS customers in Salesforce #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
| // to ignore https issues, enable agent and rejectUnauthorized:false bellow. | ||
| httpsAgent: new https.Agent({ | ||
| // Allow self signed negotiations | ||
| // rejectUnauthorized: false, |
There was a problem hiding this comment.
This needs to be uncommented to work locally (due to a self-signed certificate in certificate chain: error) but on prod it should work fine... I'm not that happy with this state of things so if there's a better way that allows it to work everywhere without tweaking the code that'd be ideal.
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
force-pushed
the
create-customer-endpoint
branch
from
e275934 to
8787e3d
Compare
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
GitHub Actions
Failure
added 25 commits
December 5, 2024 15:09
…rt-Finance/mdm-api into create-customer-endpoint
|
natdeanlewissoftwire
changed the base branch from
create-customer-endpoint-dnb-service
to
main
natdeanlewissoftwire
changed the base branch from
main
to
create-customer-endpoint-dnb-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
As part of the CCM project, if a customer does exist in SF, we are automatically creating it rather than relying on the manual process currently undertaken by Business Support Group. DTFS will send requests to a new customer/salesforce endpoint for MDM to create a customer in Salesforce. Technical documentation of this process is here
The corresponding feature-flagged DTFS pull request is here.
Resolution ✔️
This PR adds a "get or create" salesforce customer endpoint that does a few things:
Checks for an existing customer via Informatica. If none exists (or we return a legacy one):
Generates a URN from NUMGEN (if there isn't already one returned from a legacy record by Informatica, in which case we just use that).
Calls the new Dun and Bradstreet service (in a separate PR, here) to get a customer's DUNS number.
POSTs these along with the customer name and Companies House Number to Salesforce.
Returns the customer, including the URN to DTFS for deal submission.
Miscellaneous ➕
A tweak to the NUMGEN regex to allow customer URN creation, and a typo fix.
To be merged after this PR