Add ROS driver for Piksi gps module #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihsan314
requested changes
Jul 29, 2022
ihsan314
requested changes
Aug 8, 2022
setup_scripts/install_libsbp.sh
Outdated
| #!/bin/bash | ||
|
|
||
| echo "================================================================" | ||
| echo "Installing Siwft Navigation's Binary Protocol library || (GPS)" |
There was a problem hiding this comment.
Suggested change
| echo "Installing Siwft Navigation's Binary Protocol library || (GPS)" | |
| echo "Installing Swift Navigation's Binary Protocol library || (GPS)" |
Add supporting Swift Navigation Binary Library to external libs folder (libsbp)
ihsan314
requested changes
Aug 9, 2022
| @@ -51,7 +51,7 @@ cd $CURR_DIR | |||
| rosdep install --from-paths \ | |||
| $CURR_DIR/../src \ | |||
| $CURR_DIR/../src/external_pkgs \ | |||
| --ignore-src --rosdistro melodic --skip-keys=librealsense2 -y | |||
| --ignore-src --rosdistro melodic --skip-keys=librealsense2,libswiftnav -y | |||
There was a problem hiding this comment.
Suggested change
| --ignore-src --rosdistro melodic --skip-keys=librealsense2,libswiftnav -y | |
| --ignore-src --rosdistro melodic --skip-keys=librealsense2 --skip-keys=libswiftnav -y |
ihsan314
requested changes
Aug 9, 2022
setup_scripts/install_libsbp.sh
Outdated
| echo "Installing Swift Navigation's Binary Protocol library || (GPS)" | ||
| echo "================================================================" | ||
|
|
||
| cd external_libs/libsbp/c # get to build space |
There was a problem hiding this comment.
Suggested change
| cd external_libs/libsbp/c # get to build space | |
| cd ../external_libs/libsbp/c # get to build space |
The path was not relative to $CURR_DIR from the top level script.
ihsan314
approved these changes
Aug 9, 2022
ihsan314
pushed a commit
to ihsan314/Snowflake
that referenced
this pull request
Aug 10, 2022
* Add ROS driver for Piksi gps module Add supporting Swift Navigation Binary Library to external libs folder (libsbp) * Cleaned Up PR mistakes * More minor mistakes * Fixed name of external piksi * Told ROS to not look for libswiftnav * Fixed spelling error * fixed line 54 to make install_dependencies.sh skip libswiftnav. * fixed error in install_libspb, corrected a change directory
ihsan314
pushed a commit
to ihsan314/Snowflake
that referenced
this pull request
Aug 14, 2022
* Add ROS driver for Piksi gps module Add supporting Swift Navigation Binary Library to external libs folder (libsbp) * Cleaned Up PR mistakes * More minor mistakes * Fixed name of external piksi * Told ROS to not look for libswiftnav * Fixed spelling error * fixed line 54 to make install_dependencies.sh skip libswiftnav. * fixed error in install_libspb, corrected a change directory
ihsan314
pushed a commit
to ihsan314/Snowflake
that referenced
this pull request
Aug 15, 2022
* Add ROS driver for Piksi gps module Add supporting Swift Navigation Binary Library to external libs folder (libsbp) * Cleaned Up PR mistakes * More minor mistakes * Fixed name of external piksi * Told ROS to not look for libswiftnav * Fixed spelling error * fixed line 54 to make install_dependencies.sh skip libswiftnav. * fixed error in install_libspb, corrected a change directory
ihsan314
pushed a commit
to ihsan314/Snowflake
that referenced
this pull request
Aug 15, 2022
* Add ROS driver for Piksi gps module Add supporting Swift Navigation Binary Library to external libs folder (libsbp) * Cleaned Up PR mistakes * More minor mistakes * Fixed name of external piksi * Told ROS to not look for libswiftnav * Fixed spelling error * fixed line 54 to make install_dependencies.sh skip libswiftnav. * fixed error in install_libspb, corrected a change directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Add supporting Swift Navigation Binary Library to external libs folder (libsbp)
As well as a driver to run the module on ROS.
Not 100% sure if this is right, the external library may not download properly
Testing Done
Runs on my 18.04 computer and the precision computer
Resolved Issues
No specific issue resolved, but now the repo can use data from the GPS module.
Review Checklist
(Please check every item to indicate your code complies with it (by changing
[ ]->[x]). This will hopefully save both you and the reviewer(s) a lot of time!)It is the reviewers responsibility to also make sure every item here has been covered
.cppand.hfile should have a comment at the start of it. See files insrc/sample_packagefor examples..hfile) should have a javadoc style comment at the start of them. For examples, see the classes defined insrc/sample_packageTODO(or similar) statements should either be completed or associated with a github issueFeel free to make additions of things that we should be checking to this file if you think there's something missing!!!!