-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): Update im-metadata to v3.0.0 #55
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump im-metadata to fix #10 |
Need to update the size test to return bytes |
You got a merge commit in this branch. Can you do a rebase on master:
A tip when creating new branches is to branch from the remote branch by |
anthonyringoet
force-pushed
the
deps/im-metadata-3.0.0
branch
from
October 28, 2015 07:05
89f793b
to
11484e4
Compare
missing 'e'
Add support for `Expires` and `Caceh-Control` headers for images uploaded to AWS S3. It is good practice to cache as much as possible and adding the headers retrospectively to AWS is kind of a pain. PR-URL: #45 Signed-off-by: Hans Kristian Flaatten <[email protected]>
Add support for selecting a custom random path generator function such as `broofa/node-uuid`. PR-URL: #41 Implements: #20 Signed-off-by: Hans Kristian Flaatten <[email protected]>
This reverts commit 8d75e47.
PR-URL: #48 Signed-off-by: Hans Kristian Flaatten <[email protected]>
Set absolute path for uploaded image. This disables the random path. The final path to a version image follows the following rule: prefix + path + suffix + ext PR-URL: #47 Close: #36 #38 Related: #46 Signed-off-by: Hans Kristian Flaatten <[email protected]>
anthonyringoet
force-pushed
the
deps/im-metadata-3.0.0
branch
from
October 28, 2015 07:06
11484e4
to
63ef256
Compare
Thanks for the tip, i'll go for a new pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.