Add support for AWS S3 cache control headers #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starefossen
force-pushed
the
feature/cache-control
branch
from
0349ca7 to
f223434
Compare
Starefossen
pushed a commit
that referenced
this pull request
Sep 22, 2015
Add support for `Expires` and `Caceh-Control` headers for images uploaded to AWS S3. It is good practice to cache as much as possible and adding the headers retrospectively to AWS is kind of a pain. PR-URL: #45 Signed-off-by: Hans Kristian Flaatten <[email protected]>
|
Nice one! |
|
Do you have an idea when this will land in a new release on npm? |
| @@ -78,9 +78,13 @@ var Upload = require('s3-uploader'); | |||
| * **string** `background` - set background for transparent images (**example:** `red`) | |||
| * **boolean** `flatten` - flatten backgrund for transparent images | |||
| * **string** `awsImageAcl` - access control for AWS S3 upload (**example:** `private`) | |||
| * **number** `awsImageExpires` - add `expirex` header to image version | |||
There was a problem hiding this comment.
expirex => Expires
|
I think enough time has passed to merge and release this feature 👍 |
Add support for `Expires` and `Caceh-Control` headers for images uploaded to AWS S3. It is good practice to cache as much as possible and adding the headers retrospectively to AWS is kind of a pain. PR-URL: #45 Signed-off-by: Hans Kristian Flaatten <[email protected]>
Starefossen
force-pushed
the
feature/cache-control
branch
from
f223434 to
1661b5a
Compare
|
Cool, thanks! ⚡ |
Starefossen
pushed a commit
that referenced
this pull request
Oct 28, 2015
Add support for `Expires` and `Caceh-Control` headers for images uploaded to AWS S3. It is good practice to cache as much as possible and adding the headers retrospectively to AWS is kind of a pain. PR-URL: #45 Signed-off-by: Hans Kristian Flaatten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
ExpiresandCaceh-Controlheaders for images uploaded to AWS S3. It is good practice to cache as much as possible and adding the headers retrospectively to AWS is kind of a pain.Usage:
@DavidBennettUK I upstreamed your changes, I hope you are ok with that.
Signed-off-by: Hans Kristian Flaatten [email protected]