Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

API parameters consistency #31

Closed
rgiot opened this issue Dec 21, 2017 · 1 comment
Closed

API parameters consistency #31

rgiot opened this issue Dec 21, 2017 · 1 comment

Comments

@rgiot
Copy link
Contributor

rgiot commented Dec 21, 2017

In the same kind of cosmetic stuff as issue #30, there are also inconsistencies in the parameter orders of some methods.

For example, in the Graph class:

  bool applyAlgorithm(const std::string &algorithm, std::string &errorMessage,
                      DataSet *dataSet = NULL, PluginProgress *progress = NULL);

  bool applyPropertyAlgorithm(const std::string &algorithm, PropertyInterface *result,
                              std::string &errorMessage, PluginProgress *progress = NULL,
                              DataSet *parameters = NULL);

where:

  • parameters and progress are exchanged
  • parameters is named dataSet in the first case

I guess we can find others cases

p-mary added a commit that referenced this issue Jan 9, 2018
…ropertyAlgorithm(const std::string &algorithm, PropertyInterface *result, std::string &errorMessage, DataSet *parameters = nullptr, PluginProgress *progress = nullptr) to be consistent with Graph::applyAlgorithm, and deprecate the previously existing version
@p-mary
Copy link
Contributor

p-mary commented Jan 9, 2018

Thanks for your input.
This issue is now fixed (commit f7a3162).

@p-mary p-mary closed this as completed Jan 9, 2018
p-mary referenced this issue in anlambert/talipot Jan 3, 2020
QOpenGL module is marked as deprecated since a while now so it is time
to remove its use from the Talipot codebase and promote the use of
QOpenGL* classes directly integrated in the QtGui module.

The big difference between QOpenGL and QtOpenGL from Qt5 is that all
rendering is performed in framebuffer objects, there is no more direct
rendering in the underlying os windows with its own OpenGL context.

Talipot OpenGL rendering also follows that idiom, all renderings are performed
offscreen using a shared OpenGL context. This also means that there is no
more QGLWidget as viewport for QGraphicsView. Talipot OpenGL scene are
now converted to QImage in order to display them using the default Qt raster
rendering engine. This should fixes the numerous rendering glitches observed
on MacOS.

First thing observed after the migration is a consequent performance boost
in OpenGL rendering when using an Intel GPU on a Linux host machine (especially
when selecting elements, it is now 10 times faster on debian stable).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants