Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

Terminology consistency #30

Closed
guywiz opened this issue Dec 21, 2017 · 2 comments
Closed

Terminology consistency #30

guywiz opened this issue Dec 21, 2017 · 2 comments

Comments

@guywiz
Copy link

guywiz commented Dec 21, 2017

This is just a smallish thing.

Tulip uses a camelcase convention to write SubGraph (or subGraph) whenever denoting a subgraph of a graph.

I just noticed today (although I've been using the plugin for years) that the Reachable Sub-Graph is an exception and uses a dash :-) Dunno whether this is worth changing, I just thought I should mention it.
@guywiz
Copy link
Author

guywiz commented Dec 21, 2017

Hmm, must be the first time I try calling this plugin from within a Tulip script:

graph.applyAlgorithm('Reachable Sub-Graph', dataSet)
Exception: No Tulip algorithm plugin named Reachable Sub-Graph.

So it seems I must go through the reachable method and apply it on all selected nodes.

@rgiot rgiot mentioned this issue Dec 21, 2017
Closed
p-mary added a commit that referenced this issue Jan 15, 2018
@p-mary
fix for issue #30 (Terminology inconsistency): add a mechanism to man…
3e9c6cf 
…age plugin name deprecation + rename "Induced Sub-Graph" plugin into "Induced SubGraph" and "Reachable Sub-Graph" plugin into "Reachable SubGraph" + deprecate old names of these plugins
@p-mary
Copy link
Contributor

p-mary commented Jan 15, 2018

Thanks for your input.
This issue is now fixed (commit 3e9c6cf).

@p-mary p-mary closed this as completed Jan 15, 2018
This was referenced Apr 18, 2019
Closed
Closed
p-mary referenced this issue in anlambert/talipot Jan 3, 2020
@anlambert
qt5: Remove the use of deprecated QOpenGL module
1d1505a 
QOpenGL module is marked as deprecated since a while now so it is time
to remove its use from the Talipot codebase and promote the use of
QOpenGL* classes directly integrated in the QtGui module.

The big difference between QOpenGL and QtOpenGL from Qt5 is that all
rendering is performed in framebuffer objects, there is no more direct
rendering in the underlying os windows with its own OpenGL context.

Talipot OpenGL rendering also follows that idiom, all renderings are performed
offscreen using a shared OpenGL context. This also means that there is no
more QGLWidget as viewport for QGraphicsView. Talipot OpenGL scene are
now converted to QImage in order to display them using the default Qt raster
rendering engine. This should fixes the numerous rendering glitches observed
on MacOS.

First thing observed after the migration is a consequent performance boost
in OpenGL rendering when using an Intel GPU on a Linux host machine (especially
when selecting elements, it is now 10 times faster on debian stable).
This was referenced Mar 12, 2020
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guywiz @p-mary