Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dark mode (#1502) #2521

Merged
merged 13 commits into from
May 16, 2024
Merged

Feat/dark mode (#1502) #2521

merged 13 commits into from
May 16, 2024

Conversation

mike-kiss
Copy link
Collaborator

@mike-kiss mike-kiss commented May 11, 2024 •
edited
Loading

This PR:

  • Adds an initial dark theme and applies it.
  • Switches most components to using the useTheme hook rather than accessing the theme directly.
  • Removes some over-specified colors and unused classes.
  • Adds a setting to change back to light mode Uses the OS/browser default

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

mike-kiss added 11 commits May 10, 2024 15:35
@mike-kiss
Add dummy dark theme, convert to useTheme hook
450e02f
@mike-kiss
feat: TryQuiet#1502 Implement dark mode, tidy up loose styles and unu…
84bf50a 
…sed classes.
@mike-kiss
feat: darkmode TryQuiet#1502 update CHANGELOG
1a3ad45
@mike-kiss
feat: TryQuiet#1502 respect browser night-mode, fix sidebar and messa…
ecd239a 
…ge highlight colors
@mike-kiss
feat: TryQuiet#1502 Let's do the Emoji picker too!
17c1c67
@mike-kiss
feat: TryQuiet#1502 get light/dark from native theme and access it th…
4d80746 
…rough DRY function
@mike-kiss
feat: TryQuiet#1502 make backgrounds on channel input and settings ta…
1fb3969 
…bs the default
@mike-kiss
feat: TryQuiet#1502 Tweak more backgrounds in sidebar, Jdenticons, etc.
d3fabeb
@mike-kiss
feat: TryQuiet#1502 Replace hard-coded icons that weren't visible in …
1a1ce11 
…dark mode
@mike-kiss
feat: TryQuiet#1502 Remove hardcoded color and ensure contrast in tab…
cf106e0 
…s, more icon replacement
@mike-kiss
feat: TryQuiet#1502 tweak light-mode sidebar background
663afcd
@mike-kiss mike-kiss changed the title DRAFT: Feat/dark mode (#1502) Feat/dark mode (#1502) May 16, 2024
@mike-kiss mike-kiss requested a review from leblowl May 16, 2024 15:08
leblowl
leblowl approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@holmesworcester holmesworcester merged commit 043c082 into TryQuiet:develop May 16, 2024
19 of 31 checks passed
@holmesworcester holmesworcester mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leblowl leblowl leblowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike-kiss @leblowl @holmesworcester