-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User should be able to enable/disable dark mode in settings #2583
Comments
It's kind of janky for the user to set it per community but I think that's fine? Autodetect can be an option. It might be greyed out on Windows. |
@holmesworcester here's the Figma for draft 1.
|
Looks great! |
No thoughts on item 3? |
On item 3 I think we can wait until we've implemented enough of these options for it to require more scan-ability. |
@holmesworcester This passed Design Finishing. Here's the latest Figma: Change theme (dark, light, auto) |
In case it's helpful, this is the original PR that added dark mode: #2521 (One of those commits should include the detection code, which this setting would interact with.) |
Right now we have a working dark mode, but it depends on detecting the OS dark/light mode setting and on some platforms (some Linux distros specifically) this does not work.
We'd like users to be able to set it in the app. See designs: https://www.figma.com/design/VT7uPXCIfmI9tbyhiAMhhu/Change-theme-(dark%2C-light%2C-system-modes)?node-id=637-470&t=WzGBAFFoIhIF72sm-0
This should override the detected OS settings if "dark" or "light" is selected. The default should be for it to depend on the OS setting.
ACCEPTANCE CRITERIA:
The text was updated successfully, but these errors were encountered: