Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Lint on pre-commit with husky and lint-staged #2363 #2364

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

islathehut
Copy link
Collaborator

  • Adds husky and lint-staged
  • Adds lint-staged scripts to each package with a linter
  • Adds new lint:no-fix npm scripts to each package with a linter
  • Husky runs lint-staged on each package with a linter on pre-commit

NOTE: lint-staged only runs the linter against the files that changed so this should be pretty quick.

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@islathehut
Copy link
Collaborator Author

Completes #2363

@islathehut islathehut merged commit 0418e6a into develop Mar 18, 2024
28 of 32 checks passed
@islathehut islathehut deleted the chore-pre-commit-linting branch March 18, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants