Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint on pre-commit #2363

Closed
islathehut opened this issue Mar 14, 2024 · 0 comments
Closed

Lint on pre-commit #2363

islathehut opened this issue Mar 14, 2024 · 0 comments
Assignees
@islathehut
Labels
chore developer experience

Comments

@islathehut
Copy link
Collaborator

This may be a me-thing but I often forget to run the linter before committing and then see that code fails the linting check in CI. We should do a linting check locally on commit.
@islathehut islathehut self-assigned this Mar 14, 2024
@islathehut islathehut added this to Quiet Mar 14, 2024
@islathehut islathehut moved this to In progress in Quiet Mar 14, 2024
@islathehut islathehut mentioned this issue Mar 14, 2024
Merged
4 tasks
islathehut pushed a commit that referenced this issue Mar 18, 2024
chore: Lint on pre-commit with husky and lint-staged #2363 (#2364)
0418e6a 
* Lint on pre-commit with husky and lint-staged

* Don't lint integration-tests on ci
@leblowl leblowl moved this from In progress to Merged in Quiet Mar 20, 2024
@leblowl leblowl moved this from Merged to Done in Quiet Apr 4, 2024
@leblowl leblowl closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@islathehut islathehut

Labels
chore developer experience
Projects
Quiet
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leblowl @islathehut