Skip to content

Commit

Permalink
add todo note
Browse files Browse the repository at this point in the history
  • Loading branch information
nlaverdure committed Jan 20, 2025
1 parent b0a2614 commit 01c5d18
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/main/java/frc/robot/elevator/Elevator.java
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ private Elevator() {
.maxVelocity(ElevatorConstants.kMaxVelocity);

leaderConfig.closedLoop
// TODO: Add 2nd control loop slot, with velocity closed loop gains
// See https://github.com/REVrobotics/REVLib-Examples/blob/main/Java/SPARK/Closed%20Loop%20Control/
.feedbackSensor(FeedbackSensor.kPrimaryEncoder)
.p(ElevatorControllerGains.kP)
.i(ElevatorControllerGains.kI)
Expand Down

0 comments on commit 01c5d18

Please sign in to comment.