Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Release build on 7.14 branch #7959

Merged
merged 12 commits into from
Apr 9, 2024

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Apr 8, 2024

This PR cherry-picks the following PRs to release/7.14 branch from main:

These changes are made to support building binaries using CxFreeze instead of PyInstaller on Windows. The additional details can be found on the linked PRs and their associated issues.

Note: The last commit is not part of the cherry-picked commits but additional pylint fixes.

@xoriole
Copy link
Contributor Author

xoriole commented Apr 8, 2024

Here is the malware check report for the build:

Both binaries are marked Safe. 🎉

win64
win32

Jenkins build is here

@xoriole xoriole marked this pull request as ready for review April 9, 2024 07:56
@xoriole xoriole requested review from a team and drew2a and removed request for a team April 9, 2024 10:00
Copy link
Contributor

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it contains cherry-picked commits, therefore approval is just a formality.

@kozlovsky kozlovsky self-requested a review April 9, 2024 13:44
@xoriole xoriole merged commit 03bf513 into Tribler:release/7.14 Apr 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants