Build windows binary using Cx_Freeze #7936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoriole
requested review from
a team and
egbertbouman
and removed request for
a team
egbertbouman
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to transition from PyInstaller to Cx_Freeze for generating Windows binaries. The motivation for this change is detailed here.
Although Cx_Freeze supports MSI installer generation (refer to the build.py documentation in the PR), this feature is not utilized. Instead, the existing NSIS-based installation process is maintained, with the switch only affecting the executable creation, previously managed by PyInstaller.
It's important to note that this PR exclusively alters the Windows build process. For Linux and MacOS, PyInstaller remains the tool of choice for binary creation. This decision stems from the absence of malware misidentification issues and the significantly smaller binary size produced by PyInstaller compared to Cx_Freeze on these platforms, prompting no changes there for the time being.